noConstructRule.js
2.71 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
"use strict";
var __extends = (this && this.__extends) || function (d, b) {
for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
function __() { this.constructor = d; }
d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
};
var ts = require("typescript");
var Lint = require("../lint");
var Rule = (function (_super) {
__extends(Rule, _super);
function Rule() {
_super.apply(this, arguments);
}
Rule.prototype.apply = function (sourceFile) {
return this.applyWithWalker(new NoConstructWalker(sourceFile, this.getOptions()));
};
Rule.metadata = {
ruleName: "no-construct",
description: "Disallows access to the constructors of `String`, `Number`, and `Boolean`.",
descriptionDetails: "Disallows constructor use such as `new Number(foo)` but does not disallow `Number(foo)`.",
rationale: (_a = ["\n There is little reason to use `String`, `Number`, or `Boolean` as constructors.\n In almost all cases, the regular function-call version is more appropriate.\n [More details](http://stackoverflow.com/q/4719320/3124288) are available on StackOverflow."], _a.raw = ["\n There is little reason to use \\`String\\`, \\`Number\\`, or \\`Boolean\\` as constructors.\n In almost all cases, the regular function-call version is more appropriate.\n [More details](http://stackoverflow.com/q/4719320/3124288) are available on StackOverflow."], Lint.Utils.dedent(_a)),
optionsDescription: "Not configurable.",
options: null,
optionExamples: ["true"],
type: "functionality",
};
Rule.FAILURE_STRING = "Forbidden constructor, use a literal or simple function call instead";
return Rule;
var _a;
}(Lint.Rules.AbstractRule));
exports.Rule = Rule;
var NoConstructWalker = (function (_super) {
__extends(NoConstructWalker, _super);
function NoConstructWalker() {
_super.apply(this, arguments);
}
NoConstructWalker.prototype.visitNewExpression = function (node) {
if (node.expression.kind === ts.SyntaxKind.Identifier) {
var identifier = node.expression;
var constructorName = identifier.text;
if (NoConstructWalker.FORBIDDEN_CONSTRUCTORS.indexOf(constructorName) !== -1) {
var failure = this.createFailure(node.getStart(), identifier.getEnd() - node.getStart(), Rule.FAILURE_STRING);
this.addFailure(failure);
}
}
_super.prototype.visitNewExpression.call(this, node);
};
NoConstructWalker.FORBIDDEN_CONSTRUCTORS = [
"Boolean",
"Number",
"String",
];
return NoConstructWalker;
}(Lint.RuleWalker));